hubicfuse: 2.1.0 -> 3.0.0 #22037
Merged
hubicfuse: 2.1.0 -> 3.0.0 #22037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @lsix @lethalman |
Mic92
approved these changes
Jan 22, 2017
| @@ -5,7 +5,7 @@ stdenv.mkDerivation rec { | |||
| version = "2.1.0"; | |||
|
|
|||
| src = fetchurl { | |||
There was a problem hiding this comment.
fetchFromGitHub would be preferred here.
|
@Mic92 done. |
|
I think all the hubic-fuse related commits can be squashed under |
LnL7
reviewed
Jan 23, 2017
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "hubicfuse-${version}"; | ||
| version = "2.1.0"; | ||
| version = "v3.0.0"; |
There was a problem hiding this comment.
The version of the name must start with a digit, otherwise nix won't parse this correctly (for nix-env -u and builtins.parseDrvName) You should add the v prefix to the revision.
* bump version * fetchurl -> fetchFromGitHub
LnL7
approved these changes
Jan 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package upgrade.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)