Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flannel service: fix enable expression #22038

Merged
merged 1 commit into from Jan 22, 2017

Conversation

rycee
Copy link
Member

@rycee rycee commented Jan 22, 2017

Need to surround the equality check in parentheses, otherwise the expression is interpreted as

services.etcd.enable = (mkDefault cfg.etcd.endpoints) == ["http://127.0.0.1:2379"];

which gets very confused.

Need to surround the equality check in parentheses.
@mention-bot
Copy link

@rycee, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker and @joachifm to be potential reviewers.

@offlinehacker
Copy link
Contributor

tnx!

@offlinehacker offlinehacker merged commit 513a564 into NixOS:master Jan 22, 2017
@rycee rycee deleted the fix/flannel/service branch January 22, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants