python-protobuf: enable python3 and enable py3 tests #22061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
changed the title
7 tasks
Mic92
changed the title
- moved expression out of python-packages - no significant changes how package is built except the supported python versions
Mic92
force-pushed
the
python3-protobuf
branch
from
ecc6c90
to
094ac2d
Compare
FRidh
reviewed
Jan 31, 2017
| @@ -0,0 +1,46 @@ | |||
| { stdenv, python, buildPythonPackage | |||
| , protobuf, google_apputils | |||
| , disabled, doCheck ? true }: | |||
There was a problem hiding this comment.
Maybe
{ stdenv, python, buildPythonPackage, google_apputils }:
{ protobuf, ... } @attrs:
buildPythonPackage rec { } // attrs
---
buildProtobufPackage = callPackage .. {}
I think that is more flexible since then one can override buildProtobufPackage as if they were overriding buildPythonPackage.
|
1.0 was released so maybe we can update to that: https://github.com/tensorflow/tensorflow/releases/tag/v1.0.0 |
|
@teh Sounds good; this PR is about protobuf though, am I right? |
|
@jyp - yes you are right, apologies! I got confused with PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python versions
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)