Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchbower: fix SSL support #22059

Merged
merged 1 commit into from Jan 23, 2017
Merged

fetchbower: fix SSL support #22059

merged 1 commit into from Jan 23, 2017

Conversation

edofic
Copy link
Contributor

@edofic edofic commented Jan 23, 2017

Motivation for this change

fetchbower is does'nt handle SSL origins properly. This fixes #18454

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I tested this on a few bower packages and I successfully fetches them.

@domenkozar domenkozar merged commit d4392ae into NixOS:master Jan 23, 2017
@domenkozar
Copy link
Member

Backported to 16.09

@domenkozar domenkozar mentioned this pull request Jan 23, 2017
Open
@rvl
Copy link
Contributor

rvl commented Jan 23, 2017

Thanks @edofic + @domenkozar! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetch-bower fails fetching components when run under nix-build
4 participants
@edofic @domenkozar @rvl @Janik-Haag