Fixing the wrong Git Commit hash in docker version #22048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DOCKER_GITCOMMIT` needs to match the tagged commit used to build the binary. The current commit refers to 1.12.1 and wasn't update each time we updated the package. Using a variable near the version and adding a comment so we don't forget to update next time. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
|
@vdemeester, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @domenkozar and @benley to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOCKER_GITCOMMITneeds to match the tagged commit used to build thebinary. The current commit refers to 1.12.1 and wasn't update each
time we updated the package. Using a variable near the version and
adding a comment so we don't forget to update next time.
Signed-off-by: Vincent Demeester vincent@sbr.pm
Motivation for this change
The current output of
docker versionis incoherent (tag is 1.13.0 but the commit refers to 1.12.1). My bad for not seeing this when updating the package 馃槄 馃惢.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)