erlangR19: 19.1.6 -> 19.2 #21775
erlangR19: 19.1.6 -> 19.2 #21775
Conversation
yurrriq
force-pushed
the
update/pkgs/development/interpreters/erlang/R19
branch
from
a990bd9
to
927cb1b
Compare
| @@ -45,6 +45,8 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| preConfigure = '' | |||
| ./otp_build autoconf | |||
| '' + optionalString stdenv.isDarwin '' | |||
| substituteInPlace configure --replace "sw_vers" "/usr/bin/sw_vers" | |||
There was a problem hiding this comment.
So for me, running the "sw_vers" command without the prepended "/usr/bin/" works perfectly alright. I want to see if NixOS contains this already
There was a problem hiding this comment.
@grahamc I see it done here
. Must be a Darwin-specific protocol for getting the system version.
There was a problem hiding this comment.
yes it's darwin specific, what's this used for? If you can replace the call to the binary with a string would be a better approach.
There was a problem hiding this comment.
@LnL7 it's used to obtain specific Mac OS version info
There was a problem hiding this comment.
I just checked our stdenv sets MACOSX_DEPLOYMENT_TARGET to 10.10, that's probably what we want to use.
There was a problem hiding this comment.
I'm hacking nix-darwin atm, but I'll give that a go after.
|
Hey, @DerTim1! I appreciate the reviews you've been doing, thank you and keep up the good work! This change LGTM but just want to get a darwin person (like LnL ) to look at the change. Can you explain what that substitute does? |
|
@grahamc No problem. I thought a build von a linux-system is always useful. :) |
|
@DerTim1 Definitely! Donating some cpu cycles is always appreciated. |
yurrriq
force-pushed
the
update/pkgs/development/interpreters/erlang/R19
branch
from
5bb4d2b
to
0c4eb07
Compare
|
Rebased. |
Include sw_vers patch as discussed on NixOS#21775.
yurrriq
force-pushed
the
update/pkgs/development/interpreters/erlang/R19
branch
from
0c4eb07
to
ad3e589
Compare
Motivation for this change
Update
erlangR19from 19.1.6 to 19.2.N.B. I've added a
sw_verssubstitution fordarwin.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)