Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary C2A0 #3841

Merged
merged 2 commits into from Jan 5, 2017
Merged

Remove unnecessary C2A0 #3841

merged 2 commits into from Jan 5, 2017

Conversation

maiha
Copy link
Contributor

@maiha maiha commented Jan 4, 2017

There are some unnecessary c2a0 (NO-BREAK SPACE) in srcs.
It works but may cause some trouble in future.

@RX14
Copy link
Contributor

RX14 commented Jan 4, 2017

Shouldn't the formatter consider this whitespace using the new Unicode support?

@maiha
Copy link
Contributor Author

maiha commented Jan 4, 2017

Yup, it's good idea if formatter could detect this because it is difficult for human to notice in editors and browsers.
Although intended use of c2a0 exists like following, it doesn't disturb formatter because it must be only in string literals not program codes.
https://github.com/crystal-lang/crystal/blob/master/spec/std/html_spec.cr#L24-L25

@asterite
Copy link
Member

asterite commented Jan 5, 2017

Thank you!

@asterite asterite merged commit 3e9eb97 into crystal-lang:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants