Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make deps is back #3838

Merged
merged 1 commit into from Jan 4, 2017
Merged

make deps is back #3838

merged 1 commit into from Jan 4, 2017

Conversation

makenowjust
Copy link
Contributor

Sorry. I should asked how often use make deps and some targets (llvm_ext and libcrystal).

@asterite
Copy link
Member

asterite commented Jan 4, 2017

@makenowjust As I said, it's not a problem at all. Maybe my replies were kind of wrong/harsh too, sorry.

In fact, it was good that this happened because now I got tired of having to run deps, the file sigfault.c should be rewritten in Crystal and it'll be much easier to develop the compiler. I'll soon open an issue for that.

@makenowjust
Copy link
Contributor Author

@asterite Ah, sorry. In fact, I expected your reaction #3720 (comment). For that reason, I feel I should have asked it.

@asterite
Copy link
Member

asterite commented Jan 4, 2017

Thank you!

@asterite asterite merged commit 4c64ad3 into crystal-lang:master Jan 4, 2017
@ysbaddaden
Copy link
Contributor

Thanks, I often use deps when dealing with different LLVM versions when upgrading.

@makenowjust makenowjust deleted the fix/makefile/deps branch January 5, 2017 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makenowjust @asterite @ysbaddaden