Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StringIO thread-safe by synchronizing against ptr. #4421

Merged
merged 1 commit into from Jan 4, 2017
Merged

Make StringIO thread-safe by synchronizing against ptr. #4421

merged 1 commit into from Jan 4, 2017

Conversation

headius
Copy link
Member

@headius headius commented Jan 4, 2017

Fixes #4417.

@headius headius added this to the JRuby 9.1.7.0 milestone Jan 4, 2017
@headius
Copy link
Member Author

headius commented Jan 4, 2017

Ping @enebo, @kares for review.

@headius headius merged commit f9caf6c into jruby:master Jan 4, 2017
@headius headius deleted the stringio_threadsafe branch January 4, 2017 20:20
@kares
Copy link
Member

kares commented Jan 5, 2017

@headius 👍, thought StringIO will be declared as non thread-safe and maybe raise ConcurrencyError as an improvement but I guess it shouldn't worsen much with single threaded use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@headius @kares