Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldns 1.6.17 -> 1.7.0 #21650

Merged
merged 1 commit into from Jan 6, 2017
Merged

ldns 1.6.17 -> 1.7.0 #21650

merged 1 commit into from Jan 6, 2017

Conversation

dbalan
Copy link
Contributor

@dbalan dbalan commented Jan 4, 2017

Release notes: http://git.nlnetlabs.nl/ldns/tree/Changelog?id=release-1.7.0

Openssl-1.1.0 is used to enable offline DANE verification (Needed for the DANE-TA usage type)

configure: error: OpenSSL does not support offline DANE verification (Needed for the DANE-TA usage type).  Please upgrade OpenSSL to version >= 1.1.0 or rerun with --disable-dane-verify or --disable-dane-ta-usage
builder /nix/store/m6n021fbk5h4iywzi3n26j95ksps9mwc-ldns-1.7.0. failed with exit code 1
error: build /nix/store/m6n021fbk5h4iywzi3n26j95ksps9mwc-ldns-1.7.0. failed
drvof drvfor
Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (only for drill)
  • Fits CONTRIBUTING.md.

ldns 1.6.17 -> 1.7.0
6edb379 
Release notes: http://git.nlnetlabs.nl/ldns/tree/Changelog?id=release-1.7.0

Openssl-1.1.0 is used to enable offline DANE verification (Needed for the DANE-TA usage type)

```
configure: error: OpenSSL does not support offline DANE verification (Needed for the DANE-TA usage type).  Please upgrade OpenSSL to version >= 1.1.0 or rerun with --disable-dane-verify or --disable-dane-ta-usage
builder /nix/store/m6n021fbk5h4iywzi3n26j95ksps9mwc-ldns-1.7.0. failed with exit code 1
error: build /nix/store/m6n021fbk5h4iywzi3n26j95ksps9mwc-ldns-1.7.0. failed
drvof drvfor
```
@mention-bot
Copy link

@dbalan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @aristidb and @ttuegel to be potential reviewers.

fpletz
fpletz approved these changes Jan 5, 2017
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but changes look fine.

@ttuegel ttuegel merged commit 8633dab into NixOS:master Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dbalan @mention-bot @fpletz @pSub @ttuegel