Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: 1.13 -> 1.14.1 #21855

Merged
merged 1 commit into from Jan 15, 2017
Merged

ed: 1.13 -> 1.14.1 #21855

merged 1 commit into from Jan 15, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Jan 13, 2017

This PR is against the staging branch.

See http://lists.gnu.org/archive/html/info-gnu/2017-01/msg00004.html
for full release announcement.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @matthiasbeyer and @edolstra to be potential reviewers.

Mic92
Mic92 reviewed Jan 14, 2017
View reviewed changes
pkgs/applications/editors/ed/default.nix
"http://fossies.org/linux/privat/${name}.tar.bz2"
];
sha256 = "1iym2fsamxr886l3sz8lqzgf00bip5cr0aly8jp04f89kf5mvl0j";
url = "http://fossies.org/linux/privat/${name}.tar.gz";
Copy link
Member

@Mic92 Mic92 Jan 14, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the mirror removed again? #21757

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have remove it because the version we are looking for (1.14.1) is not present in the fedora repo. Should we wait for it to be present in this repo before we proceed with this MR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is available, but they upgraded the hash algorithm to sha512:

http://pkgs.fedoraproject.org/repo/extras/ed/ed-1.14.1.tar.bz2/sha512/84396fe4e4f0bf0b591037277ff8679a08b2883207628aaa387644ad83ca5fbdaa74a581f33310e28222d2fea32a0b8ba37e579597cc7d6145df6eb956ea75db/ed-1.14.1.tar.bz2

Copy link
Member

@vcunat vcunat Jan 15, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

md5 is easy to find out now, so we can commit it, and hopefully Fedora will mirror it soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I checked with the md5 hash and had a 404 reply, but since the sha256 version is there, I’ll use it.

@lsix
Copy link
Member Author

lsix commented Jan 15, 2017

@Mic92 I’ve updated my commit to include the fedora repo in the urls. Thanks.

@Mic92 Mic92 merged commit d8e3c20 into NixOS:staging Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@vcunat vcunat vcunat left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
1.severity: mass-rebuild 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lsix @mention-bot @Mic92 @matthiasbeyer @vcunat @7c6f434c @pSub