Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow: add 0.12.0 #21854

Closed
wants to merge 1 commit into from
Closed

tensorflow: add 0.12.0 #21854

wants to merge 1 commit into from

Conversation

grwlf
Copy link
Contributor

@grwlf grwlf commented Jan 13, 2017

Motivation for this change

Bring popular machine learning framework up to date. Make it compatible with Python3 packages.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@grwlf, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nlewo and @FRidh to be potential reviewers.

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #20794

@@ -1025,6 +1025,26 @@ in modules // {
};
};

funcsigs1 = buildPythonPackage rec {
name = "funcsigs-1.0.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have funcsigs 1.0.2, no need for adding 1.0.0

@@ -13733,6 +13753,28 @@ in modules // {
};
});

mock20 = buildPythonPackage (rec {
name = "mock-2.0.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have mock 2.0

@teh
Copy link
Contributor

teh commented Feb 15, 2017

1.0 was released as well, so maybe we can update: https://github.com/tensorflow/tensorflow/releases/tag/v1.0.0

@jyp
Copy link
Contributor

jyp commented Feb 27, 2017

Obsoleted by #23040, please close.

@globin globin closed this Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants