systemd-boot: allow setting editor security option #21853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lheckemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92, @edolstra and @dezgeg to be potential reviewers. |
grahamc
reviewed
Jan 13, 2017
|
|
||
| description = '' | ||
| Whether to allow editing the kernel command-line before | ||
| boot. It is recommended to set this to false, as it allows |
There was a problem hiding this comment.
Who recommends it be set to false?
There was a problem hiding this comment.
fpletz
approved these changes
Jan 14, 2017
globin
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Security. Currently anyone can easily gain root access on an unencrypted, powered off machine using systemd-boot from NixOS.
See also #21832
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
Note that I have NOT tested this yet!