Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yuicompressor: add bin wrapper for jar #21848

Merged
merged 1 commit into from Jan 13, 2017
Merged

Conversation

league
Copy link
Contributor

@league league commented Jan 13, 2017

yuicompressor is a JavaScript and CSS minifier, distributed as a jar
file. This change uses makeWrapper to create a corresponding bin
script, adding jre as a dependency.

Motivation for this change

I want to be able to call yuicompressor easily from a Makefile.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

yuicompressor is a JavaScript and CSS minifier, distributed as a jar
file. This change uses `makeWrapper` to create a corresponding bin
script, adding `jre` as a dependency.
@mention-bot
Copy link

@league, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jwiegley and @edolstra to be potential reviewers.

@7c6f434c 7c6f434c merged commit c5ebc05 into NixOS:master Jan 13, 2017
@league league deleted the yuicompressor-bin branch March 4, 2017 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants