Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde5: fix error message in "Add Printer" dialog #21977

Merged
merged 2 commits into from Jan 19, 2017

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

By adding missing 'system-config-printer' dbus service, we fix the following error in "Add Printer" dialog:

Failed to group devices: 'The name org.fedoraproject.Config.Printing was not provided by any .service files'

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Noticed when running on KDE (in contrast with GNOME, which probably
pulls in pycairo via some impurity).
Without it, the following error is shown in the "Add Printer" window:

Failed to group devices: 'The name org.fedoraproject.Config.Printing was not provided by any .service files'
@mention-bot
Copy link

@bjornfor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @abbradar and @ttuegel to be potential reviewers.

@@ -229,6 +229,8 @@ in
# Enable helpful DBus services.
services.udisks2.enable = true;
services.upower.enable = config.powerManagement.enable;
services.dbus.packages =
Copy link
Member

@ttuegel ttuegel Jan 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjornfor The D-Bus service should be installed automatically already; have you checked if this is the case?

EDIT: Sorry, I was confused. This is fine.

@ttuegel ttuegel merged commit 0baa434 into NixOS:master Jan 19, 2017
@bjornfor bjornfor deleted the kde-printing branch January 19, 2017 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants