Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove xorg.intelgputools in favor of intel-gpu-tools #21979

Merged
merged 1 commit into from Jan 19, 2017

Conversation

pSub
Copy link
Member

@pSub pSub commented Jan 18, 2017

Motivation for this change

There is no reason in having both and the latter is a
separate derivation and thus easier to maintain.

Closes #21976

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@pSub, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @edolstra and @vcunat to be potential reviewers.

There is no reason in having both and the latter is a
separate derivation and thus easier to maintain.

Closes #21976
@pSub pSub force-pushed the remove-duplicate-intel-gpu-tools branch from 7db0374 to 08e9919 Compare January 18, 2017 20:47
@vcunat vcunat merged commit 08e9919 into master Jan 19, 2017
vcunat added a commit that referenced this pull request Jan 19, 2017
... in favor of intel-gpu-tools.
@vcunat vcunat deleted the remove-duplicate-intel-gpu-tools branch January 19, 2017 08:45
@RonnyPfannschmidt
Copy link
Contributor

shouldnt there be a warning backward compat attribute left in place else people depending on it get a hard failure

@vcunat
Copy link
Member

vcunat commented Jan 19, 2017

I thought of it, but I found it unlikely that people used the xorg.intelgputools attribute.

@RonnyPfannschmidt
Copy link
Contributor

i see, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants