[Truffle] Add check if property is undefined for uncached specialization #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Jan 11, 2017
| @@ -58,6 +58,9 @@ public Object updateShapeAndRead(DynamicObject object) { | |||
| @TruffleBoundary | |||
| @Specialization(contains = { "readObjectFieldCached", "updateShapeAndRead" }) | |||
| protected Object readObjectFieldUncached(DynamicObject receiver) { | |||
| if(getProperty(receiver.getShape(), name) == null){ | |||
| return defaultValue; | |||
| } | |||
| return receiver.get(name, defaultValue); | |||
There was a problem hiding this comment.
This line intended to be the same since http://lafo.ssw.uni-linz.ac.at/javadoc/truffle/latest/com/oracle/truffle/api/object/DynamicObject.html#get-java.lang.Object-java.lang.Object- should return defaultValue if the property does not exist.
However, this is a problem as we have a "removed property flag" and so we need to use PropertyFlags.isDefined(property). I'll fix, thanks for the report and analysis!
eregon
added a commit
that referenced
this pull request
Jan 11, 2017
…ned. * Removing an ivar on a shared object only marks the property as "removed" but does not actually remove it to allow unsynchronized reads. * Closes #4434.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to get code review on this since I am not too familiar with this.
I was getting
instance variable not definederrors on this line when running Addressable specs: https://github.com/sporkmonger/addressable/blob/4983bf53765c83b5f06b8b9707e6c4cbc2225acb/lib/addressable/uri.rb#L2488This change resolved these errors to reduce Addressable spec failures from 62 => 9.
If I understand this correctly, it appears to me that the cached node was checking to see if a property was defined but the uncached version was not.