[Truffle] Add check if property is undefined for uncached specialization #4434
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to get code review on this since I am not too familiar with this.
I was getting
instance variable not defined
errors on this line when running Addressable specs: https://github.com/sporkmonger/addressable/blob/4983bf53765c83b5f06b8b9707e6c4cbc2225acb/lib/addressable/uri.rb#L2488This change resolved these errors to reduce Addressable spec failures from 62 => 9.
If I understand this correctly, it appears to me that the cached node was checking to see if a property was defined but the uncached version was not.