New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agnostic IPynb, supersede 1774 #1834
Conversation
…. Also create a clean notebook with agnostic properties (openable by any kernel).
…g things, but still WIP.
…and init to go one level up with the ipynb plugin.
…metadata according to the kernel name (ipynb.py). Also understand the compiler@subcompiler notation and sent the kernel name using the metadata (new_post.py).
content_subformat = None | ||
|
||
if "@" in content_format: | ||
content_format, content_subformat = tuple(content_format.split("@")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tuple()
is unnecessary and weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right... will change
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
I just cleaned up a lot of things and made Still needs to be done:
cc @damianavila |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
* just read in the file as a notebook and resave * cleaner than before by testing for "{" instead of "Write your" Signed-off-by: Chris Warrick <kwpolska@gmail.com>
We could probably go even further. Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
language_info is not needed and will be filled in by the notebook webapp. cc @damianavila Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@damianavila I introduced a lot of changes here today. Please test and review. |
@Kwpolska thanks for working on this... I was just starting to do it by myself and I thought, I have to check if Chris did not do it before proceed... I will review it in a little bit! |
@Kwpolska, I just push some minor fixes... still there seems to be an error in the TravisCI run:
Ideas about the diff? Otherwise, I tested the PR and everything works as expected, AFAIK... |
This is expected, I removed that in f571726 and thus made the site output different. Just ignore it, it will disappear as soon as I merge and rebuild the invariant master. Merging! |
Agnostic IPynb, supersede 1774
Thanks for your help!! Nice to this merged! |
Now in the nikola repo to allow easy collaboration...