Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1837 -- nikola new_post --available-compilers #1840

Merged
merged 4 commits into from Jun 23, 2015
Merged

Fix #1837 -- nikola new_post --available-compilers #1840

merged 4 commits into from Jun 23, 2015

Conversation

Kwpolska
Copy link
Member

This is #1837.

Also accessible as -F, and in nikola new_page.

Sample output (from my own blog):

$ nikola new_post --available-compilers
Available input formats:

 NAME      EXTENSIONS

 html      .html, .htm
 rest      .txt, .rst
!ipynb     .ipynb
!markdown  .md, .mdown, .markdown
~pandoc    (disabled: not in COMPILERS)
~php       (disabled: not in COMPILERS)

More compilers are available in the Plugins Index.

Compilers marked with ! and ~ require additional configuration:
    ! not in the PAGES/POSTS tuples (unused)
    ~ not in the COMPILERS dict (disabled)
Read more: https://getnikola.com/handbook.html#configuring-other-input-formats

(there is no “friendly name” field, cannot do that)

Signed-off-by: Chris Warrick kwpolska@gmail.com

@Kwpolska
Fix #1837 -- nikola new_post --available-compilers
d42e655 
Also accessible as -F, and in nikola new_page.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.5.2 milestone Jun 21, 2015
@ralsina
Copy link
Member

ralsina commented Jun 21, 2015

We can add a friendly name field for plugins, then :-)

@ralsina
Copy link
Member

ralsina commented Jun 21, 2015

Also, we should classify plugins per type, I think. It can be done inspecting the code.

@Kwpolska
Copy link
Member Author

What sort of “type” do you mean?

@Kwpolska
flake8
b4ba52a 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Kwpolska
Kwpolska reviewed Jun 21, 2015
View reviewed changes
nikola/plugins/command/new_post.py
POSTLOGGER = utils.get_logger('new_post', utils.STDERR_HANDLER)
PAGELOGGER = utils.get_logger('new_page', utils.STDERR_HANDLER)
LOGGER = POSTLOGGER


def filter_post_pages(compiler, is_post, compilers, post_pages, compiler_names):
def filter_post_pages(compiler, is_post, compilers, post_pages, compiler_names, compilers_raw=None):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralsina: are we okay with an API change here (drop =None)?

@Kwpolska
Add compiler friendly names
8c6e235 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member Author

Friendly names added. Note that the API for filter_post_pages changed substantially.

@Kwpolska
flake8
0ad31d7 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@ralsina
Copy link
Member

ralsina commented Jun 21, 2015

Compiler/task/rest extension/etc.

@Kwpolska
Copy link
Member Author

I'm not sure I understand… This plugin adds a new feature that handles
installed compilers only. What do you want to be done?

Chris Warrick https://chriswarrick.com
Sent from my Galaxy S3.
On 21 Jun 2015 22:49, "Roberto Alsina" notifications@github.com wrote:

Compiler/task/rest extension/etc.

—
Reply to this email directly or view it on GitHub
#1840 (comment).

@ralsina
Copy link
Member

ralsina commented Jun 22, 2015

@Kwpolska this sends the user to the plugins site looking for compiler plugins. We have enough plugins that actually finding the compilers takes a little while.

@Kwpolska
Copy link
Member Author

We could just add a new field to .plugin files and let users filter by that. Should not be hard to implement (but I’m not taking it, at least for now)

Kwpolska added a commit that referenced this pull request Jun 23, 2015
@Kwpolska
Merge pull request #1840 from getnikola/available-compilers
dcd17cb 
Fix #1837 -- nikola new_post --available-compilers
@Kwpolska Kwpolska merged commit dcd17cb into master Jun 23, 2015
@Kwpolska Kwpolska deleted the available-compilers branch June 23, 2015 13:13
@Kwpolska Kwpolska mentioned this pull request Jun 23, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
v7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kwpolska @ralsina