Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IO#read_nonblock #3036

Merged
merged 3 commits into from
Jul 24, 2016
Merged

Remove IO#read_nonblock #3036

merged 3 commits into from
Jul 24, 2016

Conversation

jhass
Copy link
Member

@jhass jhass commented Jul 23, 2016

No description provided.

@asterite
Copy link
Member

This is because using raw would be the same, right?

@jhass jhass force-pushed the remove_nonblock branch from e9306b5 to 161452a Compare July 23, 2016 18:43
@jhass
Copy link
Member Author

jhass commented Jul 23, 2016

Using raw doesn't has anything to do with any change of this PR, so I'm not sure what you're referring to.

@asterite
Copy link
Member

Mmm... I mean, raw plus the fact that a file descriptor is non-blocking by default would achieve the same thing as the old read_nonblock? I'm confused because I don't know what was the purpose of read_nonblock, maybe it had sense before we turned everything non-block by default?

@jhass
Copy link
Member Author

jhass commented Jul 23, 2016

I guess so yeah. raw simply affects how the terminal communicates to our process, not how the IO behaves, so it has nothing to do with that.

@asterite asterite merged commit c7b7e2c into crystal-lang:master Jul 24, 2016
@jhass jhass deleted the remove_nonblock branch July 25, 2016 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants