WIP: Add new HTTP::Headers constructors #2946
Closed
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2016 20:56
* Add HTTP::Headers#new(Hash(String, String))
Work based on the same way than HTTP::Headers.[]=(String, String)
* Add HTTP::Headers#new(Hash(String, Array(String)))
Work based on the same way than HTTP::Headers.[]=(String,
Array(String))
It allows the construction of the HTTP::Headers without using []=
Example:
HTTP::Headers.new({"User-Agent" => "CrystalBot", "Accept-Language" => "en-US,en;q=0.5"})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: found HTT::Headers{} method, so these constructors seems to be pretty useless :)
Hello, is this feature acceptable ?
HTTP::Headers#new(Hash(String, String))Work based on the same way than
HTTP::Headers.[]=(String, String)HTTP::Headers#new(Hash(String, Array(String)))Work based on the same way than
HTTP::Headers.[]=(String, Array(String))It allows the construction of the
HTTP::Headerswithout using[]=Example: