Item13897: Bug fixes

- Fixed Request were not deleting parameters. - Fixed NatEditPlugin RestSave setting Status header directly.
foswiki · Jul 8, 2016 · 2d96be2 · 2d96be2
1 parent ab60364
commit 2d96be2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/RestSave.pm b/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/RestSave.pm
@@ -55,8 +55,11 @@ sub handle {
         $app->create('Foswiki::UI::Save')->save;
 
         # get a new lease
-        my $topicObject =
-          $app->create( 'Foswiki::Meta', $request->web, $request->topic );
+        my $topicObject = $app->create(
+            'Foswiki::Meta',
+            web   => $request->web,
+            topic => $request->topic
+        );
         $topicObject->setLease( $cfgData->{LeaseLength} );
 
     }
@@ -67,8 +70,8 @@ sub handle {
     };
 
     # clear redirect enforced by a checkpoint action
-    $response->deleteHeader( "Location", "Status" );
-    $response->pushHeader( "Status", $status );
+    $response->deleteHeader("Location");
+    $response->status($status);
 
     # add validation key to HTTP header, if required
     unless ( $response->getHeader('X-Foswiki-Validation') ) {

diff --git a/core/lib/Foswiki/Request.pm b/core/lib/Foswiki/Request.pm
@@ -685,6 +685,7 @@ sub delete {
     my $this = shift;
     foreach my $p (@_) {
         next unless exists $this->_param->{$p};
+        CORE::delete $this->_param->{$p};
     }
     my %deleted_key = map { $_ => 1 } @_;
     $this->param_list( [ grep { !$deleted_key{$_} } @{ $this->param_list } ] );

diff --git a/core/lib/Foswiki/Response.pm b/core/lib/Foswiki/Response.pm
@@ -535,7 +535,7 @@ sub as_array {
     my $headers = $this->headers;
 
     ASSERT( !defined $headers->{Status},
-        "the Status header is not set implicitly" )
+        "the Status header has been set implicitly but shouldn't" )
       if DEBUG;
 
     $rc[0] = $this->status;