Extract Nanoc::Feature

nanoc · Jul 9, 2016 · 84dab0a · 84dab0a
1 parent d0c48dc
commit 84dab0a
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 2 deletions.
diff --git a/lib/nanoc/base.rb b/lib/nanoc/base.rb
@@ -25,6 +25,7 @@ module Nanoc::Int
 require_relative 'base/contracts_support'
 
 require_relative 'base/entities'
+require_relative 'base/feature'
 require_relative 'base/repos'
 require_relative 'base/services'
 require_relative 'base/views'
diff --git a/lib/nanoc/base/feature.rb b/lib/nanoc/base/feature.rb
@@ -0,0 +1,11 @@
+module Nanoc
+  # @api private
+  module Feature
+    TRUES = %w(y yes 1 t true)
+
+    def self.enabled?(name)
+      env_name = "NANOC_FEAT_#{name.upcase}"
+      TRUES.include?(ENV.fetch(env_name, 'f').downcase)
+    end
+  end
+end
diff --git a/lib/nanoc/cli/commands/compile.rb b/lib/nanoc/cli/commands/compile.rb
@@ -356,8 +356,7 @@ class StackProfProfiler < Listener
 
       # @see Listener#enable_for?
       def self.enable_for?(_command_runner)
-        # TODO: Extract
-        ENV.fetch('NANOC_FEAT_PROFILER', 'false') == 'y'
+        Nanoc::Feature.enabled?('PROFILER')
       end
 
       # @see Listener#start

diff --git a/spec/nanoc/base/feature_spec.rb b/spec/nanoc/base/feature_spec.rb
@@ -0,0 +1,25 @@
+describe Nanoc::Feature do
+  describe '.enabled?' do
+    subject { described_class.enabled?(feature_name) }
+
+    let(:feature_name) { 'magic' }
+
+    context 'disabled' do
+      %w(0 n N no No NO false False fAlSe FALSE donkey).each do |val|
+        context "set to #{val}" do
+          before { ENV['NANOC_FEAT_MAGIC'] = val }
+          it { is_expected.not_to be }
+        end
+      end
+    end
+
+    context 'enabled' do
+      %w(1 y Y yes yEs YES t True tRuE TRUE).each do |val|
+        context "set to #{val}" do
+          before { ENV['NANOC_FEAT_MAGIC'] = val }
+          it { is_expected.to be }
+        end
+      end
+    end
+  end
+end