base64: add encode and decode to io, fixed #2964 #2965
Merged
+114
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kostya So fast!! 😍 |
| @@ -67,6 +67,28 @@ module Base64 | |||
| end | |||
| end | |||
|
|
|||
| # :nodoc: | |||
| def encode(data, io : IO) | |||
| inc = 0 | |||
There was a problem hiding this comment.
@kostya This inc, LINE_SIZE and NL logic is duplicated, it also appears below. Could we extract it to a new method that tracks inc and yields the appropriate bytes? I don't know the name, probably the current to_base64 should be to_strict_base64 and this new one should be to_base64, but the names aren't very important. What do you think?
|
@kostya Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.