openrct2: init at 0.0.4 #16685

joepie91 · 2016-07-03T22:35:16Z

Motivation for this change

Package is currently missing from nixpkgs, and this fixes that :)

Things done

Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- OS X
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Not familiar with either sandboxing or nox-review and didn't find out about their existence until I went to create a PR (nor does anything really seem to explain this), so I haven't done those steps yet.

This PR adds two packages - openrct2 (marked 'unfree') and openrct2-engine (marked GPL3). The reason for this is that OpenRCT2 is an RCT2 clone that is currently in a state where there are no original assets yet. This means that in the majority of cases, the user will want to install the game using assets from the GOG installer for the original RCT2, and so that is the default.

Both for the purpose of Hydra builds and for users who want to use a different source for their game assets, the openrct2-engine package is available, which builds and installs just the OpenRCT2 engine itself. The openrct2 package will install openrct2-engine, extract the assets from the GOG installer (or ask the user for it if they haven't provided it yet), and then use a wrapper to load OpenRCT2 with the installed assets.

The wrapper currently modifies the OpenRCT2 configuration file in the user's home directory; unfortunately, this cannot be resolved until OpenRCT2/OpenRCT2#3981 is fixed.

Note that this package is only available in an i686 variant - this is intentional, as it is not currently possible to build a 64-bit version of OpenRCT2.

EDIT: Forgot to mention, I had to add a callPackages_i686 to top_level.nix as well, as it didn't exist yet.

mention-bot · 2016-07-03T22:35:26Z

@joepie91, thanks for your PR! By analyzing the annotation information on this pull request, we identified @zimbatm, @edolstra and @vcunat to be potential reviewers

janisozaur · 2016-07-04T04:50:40Z

pkgs/games/openrct2/engine.nix

@@ -0,0 +1,41 @@
+{ stdenv, fetchurl, cmake, pkgconfig
+, SDL2, SDL2_ttf, fontconfig, jansson, speexdsp, openssl, curl }:


You don't need openssl for 0.0.4

@janisozaur Hmm, the build instructions claim that it's an (optional) dependency. Are those instructions outdated?

No, they are in sync with our develop branch. You are using older version of code.

libzip is also required now.

FRidh · 2016-07-15T11:03:41Z

pkgs/top-level/all-packages.nix

+    })
+    openrct2
+    openrct2-engine;
+


if you add both to top-level, then why bother creating a set first in default.nix and then inheriting from that set?

joachifm · 2016-07-30T20:05:41Z

@joepie91 what is the status of this?

joachifm · 2016-08-27T08:53:10Z

@joepie91 ping

joepie91 · 2016-08-27T09:28:57Z

Apologies, I've been unexpectedly busy lately, and just switched my main system over to NixOS. I still need to remove the openssl dependency (and probably rebase) - I'll do that later today, after I've gotten my editor working :)

janisozaur · 2016-11-09T22:46:14Z

We have made significant strides with openrct2, it's fully functional and architecture independent (as long as we're talking little-endian archs), this could get updated to reflect that fact.

We haven't yet made a release, but we plan on having it at some point in near future.

You may also want to know that we now have run-time option to select rct2-data-path: https://github.com/OpenRCT2/OpenRCT2/blob/develop/src/cmdline/RootCommands.cpp#L88

janisozaur · 2016-11-09T22:49:40Z

pkgs/games/openrct2/gog.nix

+        a more flexible park with optionally no restrictions or
+        finance.
+      '';
+      homepage = http://www.openrct2.website/;


no www. in here.

joepie91 · 2016-11-25T02:47:42Z

I've not had enough time to look at this before due to personal circumstances, but I'll have a look at this and fix it up tomorrow.

@janisozaur: it's fully functional and architecture independent (as long as we're talking little-endian archs), this could get updated to reflect that fact.

What specifically would you like to see changed?

janisozaur · 2016-11-25T06:59:08Z

We don't require i686 anymore, so you can target native package, which I assume in most cases would be x86_64

joepie91 · 2016-11-25T14:30:58Z

@janisozaur There doesn't appear to have been a new stable release, though? http://openrct2.website still shows 0.0.4 as the latest stable release for Linux, and that one didn't support x86_64.

Or was the release changed without incrementing the version number?

matthiasbeyer · 2017-01-30T09:48:08Z

There is a 0.0.6 now. Please get this ready, I want to try it out!

Also, feel free to put my in as maintainer of the package.

copumpkin · 2017-10-11T15:14:58Z

Is this stalled?

janisozaur · 2017-10-11T17:40:03Z

@copumpkin apparently yes. If you're NixOS user, maybe you can take it up? Feel free to join our gitter chat (https://gitter.im/OpenRCT2/OpenRCT2) if you have questions

vcunat · 2017-10-15T10:14:24Z

Probably superseded by #30409

fpletz · 2017-10-20T09:59:31Z

Closing because #30409 was merged.

openrct2: init at 0.0.4

9073a11

janisozaur reviewed Jul 4, 2016
View reviewed changes

joachifm added the 8.has: package (new) label Jul 6, 2016

FRidh reviewed Jul 15, 2016
View reviewed changes

Mic92 added the 2.status: work-in-progress label Oct 2, 2016

janisozaur reviewed Nov 9, 2016

View reviewed changes

vcunat mentioned this pull request Oct 15, 2017

openrct2: init at 0.1.1 #30409

Merged

8 tasks

fpletz closed this Oct 20, 2017

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openrct2: init at 0.0.4 #16685

openrct2: init at 0.0.4 #16685

joepie91 commented Jul 3, 2016 •

edited

mention-bot commented Jul 3, 2016

janisozaur Jul 4, 2016

joepie91 Jul 4, 2016

janisozaur Jul 4, 2016

janisozaur Jan 30, 2017

FRidh Jul 15, 2016

joachifm commented Jul 30, 2016

joachifm commented Aug 27, 2016

joepie91 commented Aug 27, 2016

janisozaur commented Nov 9, 2016 •

edited

janisozaur Nov 9, 2016

joepie91 commented Nov 25, 2016 •

edited

janisozaur commented Nov 25, 2016

joepie91 commented Nov 25, 2016

matthiasbeyer commented Jan 30, 2017

copumpkin commented Oct 11, 2017

janisozaur commented Oct 11, 2017

vcunat commented Oct 15, 2017

fpletz commented Oct 20, 2017

		@@ -0,0 +1,41 @@
		{ stdenv, fetchurl, cmake, pkgconfig
		, SDL2, SDL2_ttf, fontconfig, jansson, speexdsp, openssl, curl }:

openrct2: init at 0.0.4 #16685

openrct2: init at 0.0.4 #16685

Conversation

joepie91 commented Jul 3, 2016 • edited

Motivation for this change

Things done

mention-bot commented Jul 3, 2016

janisozaur Jul 4, 2016

Choose a reason for hiding this comment

joepie91 Jul 4, 2016

Choose a reason for hiding this comment

janisozaur Jul 4, 2016

Choose a reason for hiding this comment

janisozaur Jan 30, 2017

Choose a reason for hiding this comment

FRidh Jul 15, 2016

Choose a reason for hiding this comment

joachifm commented Jul 30, 2016

joachifm commented Aug 27, 2016

joepie91 commented Aug 27, 2016

janisozaur commented Nov 9, 2016 • edited

janisozaur Nov 9, 2016

Choose a reason for hiding this comment

joepie91 commented Nov 25, 2016 • edited

janisozaur commented Nov 25, 2016

joepie91 commented Nov 25, 2016

matthiasbeyer commented Jan 30, 2017

copumpkin commented Oct 11, 2017

janisozaur commented Oct 11, 2017

vcunat commented Oct 15, 2017

fpletz commented Oct 20, 2017

joepie91 commented Jul 3, 2016 •

edited

janisozaur commented Nov 9, 2016 •

edited

joepie91 commented Nov 25, 2016 •

edited