Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded base impl #4009

Closed
wants to merge 1 commit into from

Conversation

bmulvihill
Copy link
Contributor

This removes the hardcoded base implementation for the op_lt, op_le, op_gt, and op_ge methods

Based on #3976

@headius
Copy link
Member

headius commented Jul 12, 2016

This looks fine. We'll confirm Travis is green, then I'll merge and see if there's any broken tests we can enable.

We'll probably introduce this optimization again in a safe way once I set up a mechanism for knowing whether a core class method has been overwritten.

@headius headius added this to the JRuby 9.1.3.0 milestone Jul 12, 2016
@headius
Copy link
Member

headius commented Jul 26, 2016

As it happened, I started introducing the aforementioned mechanism for other reasons. I will reject this in favor of the optimized approach. Thanks for your help!

@headius headius closed this Jul 26, 2016
@bmulvihill bmulvihill deleted the allow-str-cmp-override branch July 26, 2016 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants