Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exif filtering (fixes #2323) #2396

Merged
merged 24 commits into from Jul 20, 2016
Merged

Add exif filtering (fixes #2323) #2396

merged 24 commits into from Jul 20, 2016

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Jul 18, 2016 •
edited

Missing:

  • Any sort of checking it works
  • Some images are just copied and bypass EXIF handling!
  • Docs

@ralsina ralsina changed the title WIP: Add exif filtering Add exif filtering (fixes #2323) Jul 19, 2016
@ralsina ralsina mentioned this pull request Jul 19, 2016
Closed
@ralsina
Copy link
Member Author

ralsina commented Jul 19, 2016

@Kwpolska if you can take a look and see if this makes sense, much appreciated.

Kwpolska
Kwpolska reviewed Jul 19, 2016
View reviewed changes
nikola/image_processing.py
def filter_exif(self, exif, whitelist):
"""Filter EXIF data as described in the documentation."""
self._fill_exif_tag_names()
exif = exif.copy() # Don't modify in-place, it's rude
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimize this by putting it after the first two ifs.

@Kwpolska
Copy link
Member

I’m not an Exif/photo expert, but LGTM as far as the code is concerned.

@Kwpolska
Copy link
Member

Feel free to merge.

@ralsina ralsina merged commit 241bfd6 into master Jul 20, 2016
@ralsina ralsina deleted the add-exif-filtering branch July 20, 2016 11:33
@ralsina
Copy link
Member Author

ralsina commented Jul 20, 2016

Thanks for checking it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska