don't pop the dict while iterating it

getnikola · Jul 18, 2016 · c53ad18 · c53ad18
1 parent 5c9d11e
commit c53ad18
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/nikola/image_processing.py b/nikola/image_processing.py
@@ -79,17 +79,17 @@ def filter_exif(self, exif, whitelist):
             return {}
 
         # Scenario 3: keep some
-        for k in exif:
+        for k in list(exif.keys()):
             if type(exif[k]) != dict:
                 pass  # At least thumbnails have no fields
-            if k not in whitelist:
+            elif k not in whitelist:
                 exif.pop(k)  # Not whitelisted, remove
             elif k in whitelist and whitelist[k] == '*':
                 # Fully whitelisted, keep all
                 pass
             else:
                 # Partially whitelisted
-                for tag in exif[k]:
+                for tag in list(exif[k].keys()):
                     if EXIF_TAG_NAMES[tag] not in whitelist[k]:
                         exif[k].pop(tag)