Temporarily disable "testStartStopWait" Threading unit test on mac

est31 · est31 · commit c1bdb552bc3e · 2016-07-04T22:46:52.000+02:00
The "testStartStopWait" unit test is unreliably failing on mac, for some time already. See bug #3786. Having the unittest fail unreliably doesn't help anybody but mostly inhibits the main feature of travis builds: to test PRs for regressions. Therefore, disable the specific unit test for until bug #3786 is fixed.
diff --git a/src/unittest/test_threading.cpp b/src/unittest/test_threading.cpp
@@ -39,7 +39,9 @@ static TestThreading g_test_instance;
 
 void TestThreading::runTests(IGameDef *gamedef)
 {
+#if !(defined(__MACH__) && defined(__APPLE__))
 	TEST(testStartStopWait);
+#endif
 	TEST(testThreadKill);
 	TEST(testAtomicSemaphoreThread);
 }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,9 @@ static TestThreading g_test_instance;`
`39`	`39`
`40`	`40`	`void TestThreading::runTests(IGameDef *gamedef)`
`41`	`41`	`{`
	`42`	`+#if !(defined(__MACH__) && defined(__APPLE__))`
`42`	`43`	`TEST(testStartStopWait);`
	`44`	`+#endif`
`43`	`45`	`TEST(testThreadKill);`
`44`	`46`	`TEST(testAtomicSemaphoreThread);`
`45`	`47`	`}`