BigInts should use gmp implementation of gcd and lcm #3039
Merged
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # # Number Theoretic Functions | ||
|
|
||
| fun gcd = __gmpz_gcd(rop : MPZ*, op1 : MPZ*, op2 : MPZ*) | ||
| fun gcd_ui = __gmpz_gcd_ui(rop : MPZ*, op1 : MPZ*, op2 : MPZ*) : Int |
There was a problem hiding this comment.
This binding (and lcm_ui) should have op2 be ULong: https://gmplib.org/manual/Number-Theoretic-Functions.html#index-mpz_005fgcd_005fui
|
@endSly Thank you, this is excellent! I made a few comments, mostly for the overloads that accept an |
endSly
force-pushed
the
master
branch
2 times, most recently
from
2b0f786 to
e465360
Compare
|
Fixed, now operations with ints uses |
|
Thank you again! ❤️ |
| end | ||
|
|
||
| def lcm(other : Int) : BigInt | ||
| BigInt.new { |mpz| LibGMP.lcm_ui(mpz, self, other.abs.to_u64) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using gmp methods to calculate gcd and lcm of bigints performance is improved by 4x to 16x.
Simple benchmark.