Skip to content

Commit 483cca7

Browse files
committedJul 8, 2016
Fix -Wterminate warning on GCC 6
Fixes #4137
1 parent 795f1c7 commit 483cca7

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed
 

‎src/database-sqlite3.cpp

+9-3
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,14 @@ SQLite format specification:
5656
SQLOK(sqlite3_prepare_v2(m_database, query, -1, &m_stmt_##name, NULL),\
5757
"Failed to prepare query '" query "'")
5858

59-
#define FINALIZE_STATEMENT(statement) \
60-
SQLOK(sqlite3_finalize(statement), "Failed to finalize " #statement)
59+
#define SQLOK_ERRSTREAM(s, m) \
60+
if ((s) != SQLITE_OK) { \
61+
errorstream << (m) << ": " \
62+
<< sqlite3_errmsg(m_database) << std::endl; \
63+
}
64+
65+
#define FINALIZE_STATEMENT(statement) SQLOK_ERRSTREAM(sqlite3_finalize(statement), \
66+
"Failed to finalize " #statement)
6167

6268
int Database_SQLite3::busyHandler(void *data, int count)
6369
{
@@ -289,6 +295,6 @@ Database_SQLite3::~Database_SQLite3()
289295
FINALIZE_STATEMENT(m_stmt_end)
290296
FINALIZE_STATEMENT(m_stmt_delete)
291297

292-
SQLOK(sqlite3_close(m_database), "Failed to close database");
298+
SQLOK_ERRSTREAM(sqlite3_close(m_database), "Failed to close database");
293299
}
294300

0 commit comments

Comments
 (0)
Please sign in to comment.