Add OptionParser#missing_option and OptionParser#invalid_option #3030
+51
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| invalid_option { |flag| raise InvalidOption.new(flag) } | ||
| # TODO: these should work and remove the need for the property! calls above | ||
| # @missing_option = ->(option : String) { raise MissingOption.new(option) } | ||
| # @invalid_option = ->(option : String) { raise InvalidOption.new(option) } |
There was a problem hiding this comment.
@asterite whether this is accepted or not, this is a bug you should look into ;)
instance variable '@missing_option' of OptionParser must be Proc(String, Nil), not Proc(String, NoReturn)
There was a problem hiding this comment.
Fixed! Of course we can't immediately use this, but please check if the new compiler now compiles this fine :-)
These callbacks provide a nicer API to toplevel option parsing, removing the need to rescue the exceptions and store the parser in a local in order to provide the help message in these events.
jhass
force-pushed
the
option_parser_handlers
branch
from
b6e9f52 to
12648f4
Compare
|
Really good idea, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These callbacks provide a nicer API to toplevel option parsing,
removing the need to rescue the exceptions and store the parser in a
local in order to provide the help message in these events.