SecureRandom: use getrandom (linux) and /dev/urandom #2959
Conversation
| return buf | ||
| end | ||
|
|
||
| ifdef !without_openssl |
There was a problem hiding this comment.
Should use {% if !flag?(:without_openssl) %} already.
There was a problem hiding this comment.
I checked and we don't use the flag? macro method but ifdef everywhere in the core/stdlib.
There was a problem hiding this comment.
Damn, it got merged just after I branched!
There was a problem hiding this comment.
It sill has some gotchas:
class variable '@@getrandom_available' of SecureRandom must be Bool, not Nil
I can't restrict the class variable to only exist for linux targets anymore.
There was a problem hiding this comment.
Errata: 0.18.7 failed, but master was capable to compile it.
ysbaddaden
force-pushed
the
std-securerandom-getrandom-urandom
branch
from
86a3e7b to
a985671
Compare
|
It seems that the CI build fail because |
|
Bet that's 104c9b9 Time to rebase! ;) |
ysbaddaden
force-pushed
the
std-securerandom-getrandom-urandom
branch
from
a985671 to
3f75853
Compare
|
Rebased to use the |
The implementation follows libsodium's sysrandom implementation, but limited to `getrandom(2)` (linux) and `/dev/urandom` since we don't support the other platforms yet (Windows, OpenBSD) and the `arc4random` functions don't seem safe on FreeBSD (?). closes crystal-lang#2792
ysbaddaden
force-pushed
the
std-securerandom-getrandom-urandom
branch
from
3f75853 to
e776bce
Compare
|
Green :) |
|
Before merging this please let @waj take a look at this. Thanks! |
| # implementation and uses `getrandom` on Linux (when provided by the kernel), | ||
| # then tries to read from `/dev/urandom`. | ||
| # | ||
| # Unlike libsodium, this implementation eventually falls back to using the RNG |
There was a problem hiding this comment.
See https://twitter.com/jedisct1/status/750980890340237313:
But why?
|
@waj bump. I'd love to have this in 0.19 :-) |
|
I reviewed this and it looks good (plus travis passes). Let's merge. Thank you! |
|
Woot! |
The implementation follows libsodium's sysrandom implementation, but limited to
getrandom(2)(linux) and/dev/urandomsince we don't support the other platforms yet (Windows, OpenBSD) and thearc4randomfunctions don't seem safe on FreeBSD (?).closes #2792