Fixes badval propagation to support all badval configurations #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchristian
force-pushed
the
badval-constructor-per-pdl
branch
from
7123a3b
to
ca57882
Compare
wchristian
force-pushed
the
badval-constructor-per-pdl
branch
from
42942d6
to
7123a3b
Compare
zmughal
force-pushed
the
badval-constructor-per-pdl
branch
from
42942d6
to
d722c4e
Compare
The changes in <#188> broke the build for all cases of `BADVAL_USENAN` xor `BADVAL_PER_PDL`. This was because the checking for badvalues when copying in `pdl_kludge_copy_*` did not take into account these variations in accessing and setting the badvalue. For example, a simple comparison using `==` is not valid when NaN values are being compared. Here we need to use `!finite(...)` to make the comparison if the type can use NaN values.
zmughal
force-pushed
the
badval-constructor-per-pdl
branch
from
d722c4e
to
015d9fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #188 broke the
build for all cases of
BADVAL_USENANxorBADVAL_PER_PDL.This was because the checking for badvalues when copying in
pdl_kludge_copy_*did not take into account these variations inaccessing and setting the badvalue.
For example, a simple comparison using
==is not valid when NaN values are being compared. Here we need to use!finite(...)to make the comparison if the type can use NaN values.Related thread: http://comments.gmane.org/gmane.comp.lang.perl.pdl.devel/6862.