Fix pkg-config: command not found errors #3018
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OS X I sometimes get the following output on stderr:
From what I can tell from scanning through the source I think this is because
src/openssl/lib_crypto.cr
andsrc/openssl/lib_ssl.cr
call out to pkg-config without checking if pkg-config exists (unlikesrc/compiler/crystal/codegen/link.cr
which checks).A better fix might be to explicitly declare the alternate flags, but I don't know enough about dealing with system libs and your preferences on how to structure that, so I've gone for the simpler fix of redirecting to /dev/null (as
src/llvm/lib_llvm.cr
does).