IO#encoding fix #3052
Closed
IO#encoding fix #3052
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this error: in /opt/crystal/src/io.cr:875: type must be String, not (IO::EncodingOptions | String) def encoding : String
|
Thank you! Maybe you can add a spec to MemoryIO, checking this? |
|
My Linux installation (with Git configured and all) doesn't boot anymore so I can only change one file at a time via github itself. If you don't mind having a separate PR for the spec I can go ahead and do it. |
|
If you don't mind, I can commit the fix with the spec directly to master (it's a very small change) |
|
Done. |
|
Merged in 7e9bd70. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error.