Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rubinius::KERNEL_PATH constant #3686

Closed
wants to merge 1 commit into from

Conversation

nomadium
Copy link
Contributor

Without this commit, I'm unable to get working the rubinius-debugger gem.

This is the bug I'm experiencing:

ubuntu@ip-172-31-1-125:~/rubinius$ ruby -v
rubinius 3.49 (2.3.1 0c24d047 2016-07-22 3.6.0) [x86_64-linux-gnu]
ubuntu@ip-172-31-1-125:~/rubinius$ irb
irb(main):001:0> require "rubinius/debugger"
NameError: Missing or uninitialized constant: Rubinius::KERNEL_PATH
        from core/module.rb:548:in `const_missing'
        from /home/ubuntu/.rubies/rbx-3.49/gems/gems/rubinius-debugger-2.4/lib/rubinius/debugger.rb:20:in `__script__'
        from /home/ubuntu/.rubies/rbx-3.49/gems/gems/rubinius-debugger-2.4/lib/rubinius/debugger.rb:16:in `__script__'
        from core/code_loader.rb:233:in `require'
        from core/kernel.rb:856:in `gem_original_require (require)'
        from /home/ubuntu/.rubies/rbx-3.49/library/rubygems/core_ext/kernel_require.rb:55:in `require'
        from (irb):1
        from core/block_environment.rb:147:in `call_on_instance'
        from core/kernel.rb:1135:in `eval'
        from core/kernel.rb:590:in `loop'
        from core/proc.rb:20:in `call'
        from core/kernel.rb:1072:in `catch'
        from core/throw_catch.rb:8:in `register'
        from core/kernel.rb:1071:in `catch'
        from core/proc.rb:20:in `call'
        from core/kernel.rb:1072:in `catch'
        from core/throw_catch.rb:8:in `register'
        from core/kernel.rb:1071:in `catch'
        from /home/ubuntu/.rubies/rbx-3.49/gems/gems/rubysl-irb-2.1.1/bin/irb:12:in `__script__'
        from core/kernel.rb:577:in `load'
        from /home/ubuntu/.rubies/rbx-3.49/gems/bin/irb:22:in `__script__'
        from core/code_loader.rb:505:in `load_script'
        from core/code_loader.rb:590:in `load_script'
        from core/loader.rb:679:in `script'
        from core/loader.rb:862:in `main'irb(main):002:0> 

This is an unexpected behaviour vs. what is described in the documentation:

http://rubinius.com/doc/en/tools/debugger/

There is also code in the pry gem referencing this missing constant:

https://github.com/pry/pry/blob/v0.10.4/lib/pry/rbx_path.rb#L10

@brixen
Copy link
Member

brixen commented Jul 26, 2016

@nomadium this constant was deprecated and removed. CORE_PATH needs to be used instead. If you can patch Rubinius debugger, that would be a big help. Pry will either need to alias the constant or update to use CORE_PATH.

@brixen brixen closed this Jul 26, 2016
@nomadium
Copy link
Contributor Author

@brixen Good to know, I'll send patches for rubinius-debugger and pry tomorrow. Thanks for the clarification.

@nomadium nomadium deleted the add-kernel-path branch July 26, 2016 22:59
@brixen
Copy link
Member

brixen commented Jul 26, 2016

@nomadium no problem, thanks for the help. BTW, rbx --deprecated will show the current deprecations and alternatives, but it's not historical. If you have suggestions for a good way to show this over time, it could be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants