[WIP] systemd-bootchart part 2 #16930
Conversation
|
@akavel, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @wkennington and @zohl to be potential reviewers |
| @@ -21,6 +21,13 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| buildInputs = [ systemd ]; | |||
|
|
|||
| patches = [ | |||
| # https://github.com/systemd/systemd-bootchart/pull/10 | |||
| ./bootchart-fix-processes-graph.patch | |||
There was a problem hiding this comment.
It's better to use fetchpatch there -- we try not to store any patches in the tree. For example, the first patch's URL is https://github.com/akavel/systemd-bootchart/commit/c5e0f0e2669b048502fdd9c4d1116bf2fb22c20f.patch
|
@akavel you can submit a PR against the branch the original PR was made from, and if the owner of that branch accepts your PR, the original PR will be automatically updated. |
|
Hm, I thought about this but the downside is that there might be other potential reviewers and interested parties and making a PR to my fork hides it from them. Maybe it's overthinking on my part, though... |
|
That's perfectly fine. @akavel said they didn't know how, so I just provided the information. |
|
Are these any updates on this issues? |
|
Closing due to lack of activity, feel free to reopen this if needed. |
Motivation for this change
Extend PR #16902 with patches fixing broken rendering of the processes graph in systemd-bootchart.
(I'm OK if my commit is moved to @abbradar's PR and "my" PR then closed; didn't know how to submit the commit otherwise on top of the previous PR.)
Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)