Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PDLPorters/pdl
base: dcebe92dc4b1
Choose a base ref
...
head repository: PDLPorters/pdl
compare: 015d9fe5c91f
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jul 11, 2016

  1. Fixes badval propagation to support all badval configurations 

    The changes in <#188> broke the
build for all cases of `BADVAL_USENAN` xor `BADVAL_PER_PDL`.

This was because the checking for badvalues when copying in
`pdl_kludge_copy_*` did not take into account these variations in
accessing and setting the badvalue.

For example, a simple comparison using `==` is not valid when NaN
values are being compared. Here we need to use `!finite(...)` to make
the comparison if the type can use NaN values.
    @zmughal
    zmughal committed Jul 11, 2016
    Copy the full SHA
    015d9fe View commit details
    Browse the repository at this point in the history