[WIP] Fix recording output format #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
${PWD} is used in python-api/Makefile to set the PYTHONPATH. When using -C the
value of PWD remains the top level directory rather than the python-api
directory leading to import-errors when running pylint.
| make PYTHONVERSION=2.7 -Cpython-api style unittests integration | ||
| make PYTHONVERSION=3.4 -Cpython-api style unittests integration | ||
| cd python-api; make PYTHONVERSION=2.7 style unittests integration | ||
| cd python-api; make PYTHONVERSION=3.4 style unittests integration |
There was a problem hiding this comment.
why exactly are you changing this?
ah, just read the commit message
There was a problem hiding this comment.
Oops that should be in a different pull request. See the comment on the commit bd70921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.