Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to directory rather than using -C so ${PWD} is correct. #215

Merged
merged 1 commit into from May 6, 2015
Merged

Change to directory rather than using -C so ${PWD} is correct. #215

merged 1 commit into from May 6, 2015

Conversation

mithro
Copy link
Member

@mithro mithro commented May 5, 2015

${PWD} is used in python-api/Makefile to set the PYTHONPATH. When using -C the value of PWD remains the top level directory rather than the python-api directory leading to import-errors when running pylint.

python2.7 /usr/local/bin/pylint --rcfile=.pylintrc_unittests tests/unittests/*
************* Module unittests.test_connection_unit
I:189, 0: Locally disabling unpacking-non-sequence (W0633) (locally-disabled)
F:  6, 0: Unable to import 'gstswitch.connection' (import-error)
F:  7, 0: Unable to import 'gstswitch.exception' (import-error)
************* Module unittests.test_controller_unit
F:  6, 0: Unable to import 'gstswitch.controller' (import-error)
F:  7, 0: Unable to import 'gstswitch.exception' (import-error)
F: 10, 0: Unable to import 'gstswitch.connection' (import-error)
************* Module unittests.test_helpers_unit
F:  6, 0: Unable to import 'gstswitch.helpers' (import-error)
F:  7, 0: Unable to import 'gstswitch.exception' (import-error)
F:  9, 0: Unable to import 'gstswitch' (import-error)
************* Module unittests.test_processmonitor_unit
F:  6, 0: Unable to import 'gstswitch.server' (import-error)
F:  8, 0: Unable to import 'gstswitch.exception' (import-error)
F:  9, 0: Unable to import 'gstswitch.exception' (import-error)
************* Module unittests.test_server_unit
F:  6, 0: Unable to import 'gstswitch.server' (import-error)
F:  8, 0: Unable to import 'gstswitch.exception' (import-error)
F:  9, 0: Unable to import 'gstswitch.exception' (import-error)
************* Module unittests.test_testsource_unit
F:  6, 0: Unable to import 'gstswitch.exception' (import-error)
F:  7, 0: Unable to import 'gstswitch.testsource' (import-error)
F:  8, 0: Unable to import 'gstswitch.testsource' (import-error)
make[1]: *** [lint] Error 1
make[1]: Leaving directory `/usr/local/google/home/tansell/foss/timvideos/gst-switch/gst-switch/python-api'
make: *** [test] Error 2

@mithro
Change to directory rather than using -C so ${PWD} is correct.
9dfce30 
${PWD} is used in python-api/Makefile to set the PYTHONPATH. When using -C the
value of PWD remains the top level directory rather than the python-api
directory leading to import-errors when running pylint.
@MaZderMind
Copy link

which command did you run to see the pylint import errors? make test in the root works for me (it tests everything that travis does in both python2 and python3).

Besiges the tests seem to work fine, so no objections to pull it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.91% when pulling 9dfce30 on mithro:makefile-fix into 00da708 on timvideos:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 9dfce30 on mithro:makefile-fix into 00da708 on timvideos:master.

@mithro
Copy link
Member Author

mithro commented May 5, 2015

I'm running make test in the root level directory here on Ubuntu Trusty, so I think it might have something to do with different Ubuntu versions?

MaZderMind added a commit that referenced this pull request May 6, 2015
@MaZderMind
Merge pull request #215 from mithro/makefile-fix
5297e23 
Change to directory rather than using -C so ${PWD} is correct.
@MaZderMind MaZderMind merged commit 5297e23 into timvideos:master May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python-api
Projects
None yet
Milestone
No milestone
4 participants
@mithro @MaZderMind @coveralls @landscape-bot