Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check 404 (Issue #1684) #1693

Merged
merged 6 commits into from May 6, 2015
Merged

Check 404 (Issue #1684) #1693

merged 6 commits into from May 6, 2015

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented May 6, 2015

A simplistic remote link checker.

rv = False
self.whitelist = [re.compile(x) for x in self.site.config['LINK_CHECK_WHITELIST']]
base_url = urlparse(self.site.config['BASE_URL'])
self.existing_targets.add(self.site.config['SITE_URL'])
self.existing_targets.add(self.site.config['BASE_URL'])
url_type = self.site.config['URL_TYPE']

if check_remote and requests is None:
utils.req_missing(['requests'], 'check remote links.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[grammar] the period should be removed, because the argument is inserted before a comma

@Kwpolska
Copy link
Member

Kwpolska commented May 6, 2015

👍 from me

ralsina added a commit that referenced this pull request May 6, 2015
@ralsina ralsina merged commit fd69359 into master May 6, 2015
@ralsina ralsina deleted the check-404 branch May 6, 2015 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants