This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Perserve the originally attempted title when resubmitting a link. #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -286,7 +286,8 @@ def GET_comments( | |||
| infotext = None | |||
| if request.GET.get('already_submitted'): | |||
| submit_url = request.GET.get('submit_url') or article.url | |||
| resubmit_url = Link.resubmit_link(submit_url) | |||
| submit_title = request.GET.get('submit_title') or article.title | |||
There was a problem hiding this comment.
Is it really appropriate to use article.title as the fallback? Wouldn't it be better to not pre-fill a title at all?
There was a problem hiding this comment.
I can see some use, although it doesn't seem too common.
If someone wants to resubmit an article, this way it would automatically supply the title as well. But I see this as being very rare. I feel like it could go either way.
There was a problem hiding this comment.
I think it's be less confusing to not pre-fill a title at all. Could you make that change?
Pokechu22
force-pushed
the
perserve-title-on-resubmit
branch
from
1220030
to
f82ada1
Compare
|
💇 |
|
Thanks, this looks good. I'm going to test it a bit and then will get it merged. |
|
Merged as c942cef What's your reddit username so I can give you a trophy? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! /u/pokechu22 here. I've added support for saving the current title when resubmitting a link, in the same way that 1c8a271 did with the full URL.