Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coverage files on make clean #208

Merged

Conversation

MaZderMind
Copy link

No description provided.

@MaZderMind MaZderMind force-pushed the remove-coverage-files-on-make-clean branch from 2975674 to b500879 Compare May 3, 2015 19:55
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling b500879 on MaZderMind:remove-coverage-files-on-make-clean into a0f8a38 on timvideos:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.89% when pulling b500879 on MaZderMind:remove-coverage-files-on-make-clean into a0f8a38 on timvideos:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.89% when pulling b500879 on MaZderMind:remove-coverage-files-on-make-clean into a0f8a38 on timvideos:master.

@@ -24,6 +24,11 @@ tests/test-switch-server: tests/test_switch_server.c \
tests/test-fd-leaks: tests/test_fd_leaks.c \
tools/*.h tools/*.c

clean-local:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage files should only exist if we are building with coverage right? Thus I think this might need to be inside the section below?

if GCOV_ENABLED

endif

You should also put a - in front of each of the rm lines, so if no files exist (and thus rm fails) it still continues. See http://www2.ipp.mpg.de/~dpc/gmake/make_47.html

@coveralls
Copy link

Coverage Status

Coverage decreased (-26.97%) to 70.92% when pulling 3467f15 on MaZderMind:remove-coverage-files-on-make-clean into a0f8a38 on timvideos:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 3467f15 on MaZderMind:remove-coverage-files-on-make-clean into a0f8a38 on timvideos:master.

@mithro
Copy link
Member

mithro commented May 4, 2015

I can't see how, but coveralls seems to think with your second patch this change reduces coverage in some way. Any thoughts on what is going on?

@MaZderMind MaZderMind force-pushed the remove-coverage-files-on-make-clean branch from 3467f15 to 68a0d50 Compare May 4, 2015 15:56
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 68a0d50 on MaZderMind:remove-coverage-files-on-make-clean into 9ad792a on timvideos:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.91% when pulling 68a0d50 on MaZderMind:remove-coverage-files-on-make-clean into 9ad792a on timvideos:master.

mithro added a commit that referenced this pull request May 5, 2015
…-clean

Remove coverage files on make clean.
@mithro mithro merged commit 00da708 into timvideos:master May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants