New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove coverage files on make clean #208
Remove coverage files on make clean #208
Conversation
2975674
to
b500879
Compare
@@ -24,6 +24,11 @@ tests/test-switch-server: tests/test_switch_server.c \ | |||
tests/test-fd-leaks: tests/test_fd_leaks.c \ | |||
tools/*.h tools/*.c | |||
|
|||
clean-local: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage files should only exist if we are building with coverage right? Thus I think this might need to be inside the section below?
if GCOV_ENABLED
endif
You should also put a -
in front of each of the rm lines, so if no files exist (and thus rm fails) it still continues. See http://www2.ipp.mpg.de/~dpc/gmake/make_47.html
I can't see how, but coveralls seems to think with your second patch this change reduces coverage in some way. Any thoughts on what is going on? |
3467f15
to
68a0d50
Compare
…-clean Remove coverage files on make clean.
No description provided.