Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.Pmw: init at 2.0.1 #26328

Closed
wants to merge 1 commit into from
Closed

pythonPackages.Pmw: init at 2.0.1 #26328

wants to merge 1 commit into from

Conversation

Mounium
Copy link
Contributor

@Mounium Mounium commented Jun 2, 2017

Motivation for this change

Pymol's optional dependency for displaying a menu

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mounium
Copy link
Contributor Author

Mounium commented Jun 2, 2017

I disabled the checkPhase because the tests all create GUIs.

@FRidh
Copy link
Member

FRidh commented Jun 2, 2017

ok, but add that as a comment to the code at doCheck = false;.

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta info is missing. Will you be the maintainer of this package?

@FRidh
Copy link
Member

FRidh commented Jun 2, 2017

Closing because this commit is already in #26317. Please make the modifications there and push an updated version.

@FRidh FRidh closed this Jun 2, 2017
@Mounium Mounium deleted the Pwm branch June 2, 2017 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants