peercoin: init 0.6.2 #26508

spinus · 2017-06-10T22:36:09Z

Motivation for this change

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

mention-bot · 2017-06-10T22:36:11Z

@spinus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @AndersonTorres, @dbrock and @jefdaj to be potential reviewers.

pkgs/applications/altcoins/peercoin.nix

Mic92 · 2017-06-11T11:56:21Z

peercoind fails to build:

these derivations will be built:
  /nix/store/zslm1jfbnrii9yxnpvspjr5518pxdm36-peercoind-0.5.4ppc.drv
building path(s) ‘/nix/store/jwncf41m24nf57mmk1sxqlprvcjdavc0-peercoind-0.5.4ppc’
unpacking sources
unpacking source archive /nix/store/wr1rhy83h8lvv7l1p9jg0v973dfy989w-peercoin-v0.5.4ppc-src
source root is peercoin-v0.5.4ppc-src
patching sources
configuring
no configure script, doing nothing
building
/nix/store/jdpwa3nmjwbcw05hxm89rsgmd6n7bk2s-stdenv/setup: line 917: qmake: command not found
builder for ‘/nix/store/zslm1jfbnrii9yxnpvspjr5518pxdm36-peercoind-0.5.4ppc.drv’ failed with exit code 127
error: build of ‘/nix/store/zslm1jfbnrii9yxnpvspjr5518pxdm36-peercoind-0.5.4ppc.drv’ failed
/run/current-system/sw/bin/nix-shell: failed to build all dependencies

spinus · 2017-06-11T14:06:26Z

@Mic92 good catch, I checked only peercoin-qt, I'll try to fix...

matthewbauer · 2018-04-21T20:53:52Z

@GrahamcOfBorg build peercoin

GrahamcOfBorg · 2018-04-21T20:54:01Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: peercoin

Partial log (click to expand)

Cannot nix-instantiate `peercoin' because:
�[31;1merror:�[0m attribute 'peercoin' in selection path 'peercoin' not found

GrahamcOfBorg · 2018-04-21T20:54:13Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: peercoin

Partial log (click to expand)

Cannot nix-instantiate `peercoin' because:
error: attribute 'peercoin' in selection path 'peercoin' not found

GrahamcOfBorg · 2018-04-21T20:54:18Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: peercoin

Partial log (click to expand)

Cannot nix-instantiate `peercoin' because:
�[31;1merror:�[0m attribute 'peercoin' in selection path 'peercoin' not found

matthewbauer · 2018-04-21T20:57:18Z

@GrahamcOfBorg build altcoins.peercoin altcoins.peercoind

GrahamcOfBorg · 2018-04-21T20:57:38Z

Failure on x86_64-linux (full log)

Attempted: altcoins.peercoin, altcoins.peercoind

Partial log (click to expand)

trying https://github.com/peercoin/peercoin/archive/v0.5.4ppc.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   128    0   128    0     0    262      0 --:--:-- --:--:-- --:--:--   262
100 1672k    0 1672k    0     0   829k      0 --:--:--  0:00:02 --:--:-- 1534k
unpacking source archive /build/v0.5.4ppc.tar.gz
fixed-output derivation produced path '/nix/store/l0hw4mxy1g4xxv84z26ql8q216m3jym5-source' with sha256 hash '0sj2q68vf3sfhhxc6w7sjyc6lj9fy72llb5blbnw52sw34xvly6w' instead of the expected hash '17k4lxa2gdy5ir5q3l0d5y7wm8fhlyww7hakiqfvj05zgc49sxjj'
cannot build derivation '/nix/store/5354qwjq6qgc59n8r8qvlfgk6z9rxpxv-peercoin-0.5.4ppc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gxhw6r4r1wswrnhwcknah1p700cr12l9-peercoind-0.5.4ppc.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/5354qwjq6qgc59n8r8qvlfgk6z9rxpxv-peercoin-0.5.4ppc.drv', '/nix/store/gxhw6r4r1wswrnhwcknah1p700cr12l9-peercoind-0.5.4ppc.drv' failed

matthewbauer

Checksum looks incorrect

GrahamcOfBorg · 2018-04-21T21:28:00Z

Failure on x86_64-darwin (full log)

Attempted: altcoins.peercoin, altcoins.peercoind

Partial log (click to expand)

../../JavaScriptCore/runtime/JSTypeInfo.h:73:52: note: use '&' for a bitwise operation
        unsigned isFinal() const { return m_flags2 && (IsJSFinalObject >> 8); }
                                                   ^~
                                                   &
../../JavaScriptCore/runtime/JSTypeInfo.h:73:52: note: remove constant to silence this warning
        unsigned isFinal() const { return m_flags2 && (IsJSFinalObject >> 8); }
                                                  ~^~~~~~~~~~~~~~~~~~~~~~~~~
building of '/nix/store/v087ch2gdfi2i7gzw6g3gmswxygxhb1j-qt-4.8.7.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/xnrhs1c2wwdh7k0g3b6a0c8slx4s6nmj-peercoin-0.5.4ppc.drv': 2 dependencies couldn't be built
error: build of '/nix/store/fzk1h1x2in6w07xrsypvpk3wqzk2ggyj-peercoind-0.5.4ppc.drv', '/nix/store/xnrhs1c2wwdh7k0g3b6a0c8slx4s6nmj-peercoin-0.5.4ppc.drv' failed

GrahamcOfBorg · 2018-04-21T21:57:58Z

Failure on aarch64-linux (full log)

Attempted: altcoins.peercoin, altcoins.peercoind

Partial log (click to expand)

helpviewer_qwv.cpp:206:9: note: here
         default:        // fall through
         ^~~~~~~
remotecontrol.cpp: In member function 'void RemoteControl::receivedData()':
remotecontrol.cpp:147:15: warning: comparison is always false due to limited range of data type [-Wtype-limits]
         if (c == EOF || c == '\0')
               ^
building of '/nix/store/7zva36frfdcfa9fpydzw2wkbx26yb163-qt-4.8.7.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/dycd4mpqivqc2nwwy96d2263p5n1cphy-peercoin-0.5.4ppc.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/6x2ifcfd4mh4fyj0yaqpddmiq17fhy8r-peercoind-0.5.4ppc.drv', '/nix/store/dycd4mpqivqc2nwwy96d2263p5n1cphy-peercoin-0.5.4ppc.drv' failed

spinus · 2018-04-22T02:04:22Z

Bumped to latest version and updated checksum. Was not sure how to build non gui target so removed that.

Mic92 · 2018-04-23T09:21:55Z

@GrahamcOfBorg build peercoin

GrahamcOfBorg · 2018-04-23T09:22:15Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: peercoin

Partial log (click to expand)

Cannot nix-instantiate `peercoin' because:
�[31;1merror:�[0m attribute 'peercoin' in selection path 'peercoin' not found

GrahamcOfBorg · 2018-04-23T09:22:16Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: peercoin

Partial log (click to expand)

Cannot nix-instantiate `peercoin' because:
error: attribute 'peercoin' in selection path 'peercoin' not found

GrahamcOfBorg · 2018-04-23T09:22:18Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: peercoin

Partial log (click to expand)

Cannot nix-instantiate `peercoin' because:
�[31;1merror:�[0m attribute 'peercoin' in selection path 'peercoin' not found

Mic92 · 2018-04-23T15:52:48Z

@GrahamcOfBorg build altcoins.peercoin

GrahamcOfBorg · 2018-04-23T15:53:20Z

Failure on x86_64-linux (full log)

Attempted: altcoins.peercoin

Partial log (click to expand)

g++ -I. -I./include -fno-builtin-memcmp -pthread -DOS_LINUX -DLEVELDB_PLATFORM_POSIX -pipe -fstack-protector-all -D_FORTIFY_SOURCE=2 -O2 -c util/status.cc -o util/status.o
g++ -I. -I./include -fno-builtin-memcmp -pthread -DOS_LINUX -DLEVELDB_PLATFORM_POSIX -pipe -fstack-protector-all -D_FORTIFY_SOURCE=2 -O2 -c port/port_posix.cc -o port/port_posix.o
rm -f libleveldb.a
ar cqs -rs libleveldb.a db/builder.o db/c.o db/db_impl.o db/db_iter.o db/dbformat.o db/filename.o db/log_reader.o db/log_writer.o db/memtable.o db/repair.o db/table_cache.o db/version_edit.o db/version_set.o db/write_batch.o table/block.o table/block_builder.o table/filter_block.o table/format.o table/iterator.o table/merger.o table/table.o table/table_builder.o table/two_level_iterator.o util/arena.o util/bloom.o util/cache.o util/coding.o util/comparator.o util/crc32c.o util/env.o util/env_posix.o util/env_win.o util/filter_policy.o util/hash.o util/histogram.o util/logging.o util/options.o util/status.o port/port_posix.o
ar: two different operation options specified
make[1]: *** [Makefile:101: libleveldb.a] Error 1
make[1]: Leaving directory '/build/source/src/leveldb'
make: *** [Makefile:426: /build/source/src/leveldb/libleveldb.a] Error 2
builder for '/nix/store/l7a3lififraj48n6jmynbwdjcgdr1n5v-peercoin-0.6.2ppc.drv' failed with exit code 2
error: build of '/nix/store/l7a3lififraj48n6jmynbwdjcgdr1n5v-peercoin-0.6.2ppc.drv' failed

GrahamcOfBorg · 2018-04-23T15:53:36Z

Failure on aarch64-linux (full log)

Attempted: altcoins.peercoin

Partial log (click to expand)

                 from ./db/filename.h:14,
                 from db/builder.cc:7:
./port/atomic_pointer.h:212:2: error: #error Please implement AtomicPointer for this platform.
 #error Please implement AtomicPointer for this platform.
  ^~~~~
make[1]: *** [Makefile:206: db/builder.o] Error 1
make[1]: Leaving directory '/build/source/src/leveldb'
make: *** [Makefile:426: /build/source/src/leveldb/libleveldb.a] Error 2
builder for '/nix/store/wp7nsi3gvk7n674sw3b7mfvm37vdjj3a-peercoin-0.6.2ppc.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/wp7nsi3gvk7n674sw3b7mfvm37vdjj3a-peercoin-0.6.2ppc.drv' failed

GrahamcOfBorg · 2018-04-23T15:53:57Z

Failure on x86_64-darwin (full log)

Attempted: altcoins.peercoin

Partial log (click to expand)

        ar -q [-cTLsv] archive file ...
        ar -r [-cuTLsv] archive file ...
        ar -r [-abciuTLsv] position archive file ...
        ar -t [-TLsv] archive [file ...]
        ar -x [-ouTLsv] archive [file ...]
make[1]: *** [Makefile:101: libleveldb.a] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-peercoin-0.6.2ppc.drv-0/source/src/leveldb'
make: *** [Makefile:466: /private/tmp/nix-build-peercoin-0.6.2ppc.drv-0/source/src/leveldb/libleveldb.a] Error 2
builder for '/nix/store/av2aq2v8y17q5n4mkm1kx9s67mighnja-peercoin-0.6.2ppc.drv' failed with exit code 2
error: build of '/nix/store/av2aq2v8y17q5n4mkm1kx9s67mighnja-peercoin-0.6.2ppc.drv' failed

matthewbauer · 2018-04-23T16:18:56Z

pkgs/applications/altcoins/peercoin.nix

+{ stdenv, fetchFromGitHub
+, pkgconfig, autoreconfHook
+, openssl, db48, boost, zlib, miniupnpc
+, protobuf, utillinux, qt4, qrencode


I think we should use qt5 if possible. Qt4 is soon to be deprecated.

let me check if that even compiles

Seems like most recent release supports qt5 from the .pro file

Ekleog · 2019-02-18T22:04:22Z

(triage) @spinus Are you still planning to come back to this PR?

aanderse · 2019-05-16T01:18:54Z

(triage) @spinus Are you still planning to come back to this PR?

@spinus ping

spinus · 2019-05-16T10:43:38Z

hello, thanks for ping. Sure, I'll jump on that soon.

aanderse

Let me know if you have any questions.

aanderse · 2019-05-16T10:51:36Z

pkgs/applications/altcoins/peercoin.nix

+with stdenv.lib;
+stdenv.mkDerivation rec {
+
+  name = "peercoin" + (toString (optional (!withGui) "d")) + "-" + version;


I would suggest the package name not change depending on the withGui option or not, unless you add both variants properly named in all-packages.nix.

Please use pname = "peercoin"; and this will automatically set name = "${pname}-${version}";

aanderse · 2019-05-16T10:54:12Z

pkgs/applications/altcoins/peercoin.nix

+stdenv.mkDerivation rec {
+
+  name = "peercoin" + (toString (optional (!withGui) "d")) + "-" + version;
+  version = "0.6.2ppc";


Looks like this can be bumped.

aanderse · 2019-05-16T10:55:47Z

pkgs/applications/altcoins/peercoin.nix

+    sha256 = "16wxwwrv83x0qjj4dndlkrpw9ril9j0rh6skp1q1xm5zyc0fx0xl";
+  };
+
+  nativeBuildInputs = [ pkgconfig ];


Please add qmake and then I believe you can omit the custom buildPhase and installPhase

aanderse · 2019-05-16T10:57:11Z

pkgs/applications/altcoins/peercoin.nix

+      the regular computers and GPUs most people already have.
+      The Litecoin network is scheduled to produce 84 million currency units.
+    '';
+    homepage = https://peercoin.org/;


Please quote as quotes will likely become mandatory at some point.

aanderse · 2019-05-16T10:58:32Z

pkgs/applications/altcoins/peercoin.nix

+    homepage = https://peercoin.org/;
+    platforms = platforms.unix;
+    license = licenses.mit;
+    maintainers = with maintainers; [ offline AndersonTorres ];  


A copy+paste need updating?

aanderse · 2019-05-16T11:01:02Z

pkgs/applications/altcoins/peercoin.nix

+{ stdenv, fetchFromGitHub
+, pkgconfig, autoreconfHook
+, openssl, db48, boost, zlib, miniupnpc
+, protobuf, utillinux, qt4, qrencode


Seems like most recent release supports qt5 from the .pro file

wamserma · 2020-03-19T10:41:49Z

@spinus Seems this is not really missing in NixOS. Maybe close this PR and provide package via NUR.

spinus · 2020-03-19T20:07:19Z

@wamserma not bad option. I thought I'll add this here as the arch for adding more tools in that category is easy and prepared. But I guess you could be right :-)

Mic92 reviewed Jun 10, 2017

View reviewed changes

pkgs/applications/altcoins/peercoin.nix Outdated Show resolved Hide resolved

joachifm added the 8.has: package (new) label Jun 16, 2017

joachifm added 2.status: work-in-progress 2.status: merge conflict labels Feb 20, 2018

GrahamcOfBorg removed the 2.status: merge conflict label Apr 21, 2018

matthewbauer requested changes Apr 21, 2018

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 21, 2018

spinus force-pushed the peercoin branch 2 times, most recently from 3bd0008 to 3e2f0ea Compare April 22, 2018 02:02

spinus changed the title ~~peercoin: init 0.5~~ peercoin: init 0.6.2 Apr 22, 2018

peercoin: init 0.6.2

0d857af

spinus force-pushed the peercoin branch from 3e2f0ea to 0d857af Compare April 22, 2018 02:08

GrahamcOfBorg added 2.status: merge conflict and removed 2.status: merge conflict labels Apr 22, 2018

matthewbauer approved these changes Apr 23, 2018

View reviewed changes

matthewbauer requested changes Apr 23, 2018

View reviewed changes

veprbl added the 2.status: merge conflict label Nov 28, 2018

aanderse requested changes May 16, 2019

View reviewed changes

spinus closed this Mar 19, 2020

peercoin: init 0.6.2 #26508

peercoin: init 0.6.2 #26508

Conversation

spinus commented Jun 10, 2017

Motivation for this change

Things done

mention-bot commented Jun 10, 2017

Mic92 commented Jun 11, 2017

spinus commented Jun 11, 2017

matthewbauer commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

matthewbauer commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

matthewbauer left a comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

spinus commented Apr 22, 2018

Mic92 commented Apr 23, 2018

GrahamcOfBorg commented Apr 23, 2018

GrahamcOfBorg commented Apr 23, 2018

GrahamcOfBorg commented Apr 23, 2018

Mic92 commented Apr 23, 2018

GrahamcOfBorg commented Apr 23, 2018

GrahamcOfBorg commented Apr 23, 2018

GrahamcOfBorg commented Apr 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ekleog commented Feb 18, 2019

aanderse commented May 16, 2019

spinus commented May 16, 2019

aanderse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wamserma commented Mar 19, 2020

spinus commented Mar 19, 2020