Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toggl: init at 7.4.45 #26510

Closed
wants to merge 1 commit into from
Closed

toggl: init at 7.4.45 #26510

wants to merge 1 commit into from

Conversation

spinus
Copy link
Member

@spinus spinus commented Jun 10, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@spinus
Copy link
Member Author

spinus commented Jun 10, 2017 •
edited

It does not compile, I'm not sure what's missing. Maybe somebody with qt exp could take a look?

ry.so.1 -o libTogglDesktopLibrary.so.1.0.0 base_model.o batch_update_result.o client.o idle.o analytics.o help_article.o autotracker.o urls.o migrations.o context.o custom_error_handler.o database.o feedback.o formatter.o get_focused_window_linux.o error.o gui.o netconf.o https_client.o jsoncpp.o toggl_api.o toggl_api_private.o model_change.o obm_action.o project.o proxy.o related_data.o settings.o tag.o task.o timeline_event.o time_entry.o timeline_uploader.o user.o websocket_client.o window_change_recorder.o workspace.o lapi.o lauxlib.o lbaselib.o lbitlib.o lcode.o lcorolib.o lctype.o ldblib.o ldebug.o ldo.o ldump.o lfunc.o lgc.o linit.o liolib.o llex.o lmathlib.o lmem.o loadlib.o lobject.o lopcodes.o loslib.o lparser.o lstate.o lstring.o lstrlib.o ltable.o ltablib.o ltm.o luac.o lundump.o lutf8lib.o lvm.o lzio.o  -L/nix/store/078ajpm0m555xpm6hvjddb1mppn1yfv7-mesa-noglu-17.1.1/lib -L/tmp/nix-build-toggl.drv-0/toggldesktop-v7.4.45-src/src/lib/linux/TogglDesktopLibrary/ -L/tmp/nix-build-toggl.drv-0/toggldesktop-v7.4.45-src/src/lib/linux/TogglDesktopLibrary/../../../../third_party/poco/lib/Linux/x86_64 -lPocoDataSQLite -lPocoData -lPocoNet -lPocoNetSSL -lPocoCrypto -lPocoUtil -lPocoXML -lPocoFoundation -L/tmp/nix-build-toggl.drv-0/toggldesktop-v7.4.45-src/src/lib/linux/TogglDesktopLibrary/../../../../third_party/openssl -lssl -lcrypto -lX11 -L/tmp/nix-build-toggl.drv-0/__nix_qt5__/lib -lQt5Gui -lQt5Core -lGL -lpthread  
loslib.o: In function `os_tmpname':
loslib.c:(.text+0x29d): warning: the use of `tmpnam' is dangerous, better use `mkstemp'
ln -s libTogglDesktopLibrary.so.1.0.0 libTogglDesktopLibrary.so
ln -s libTogglDesktopLibrary.so.1.0.0 libTogglDesktopLibrary.so.1
ln -s libTogglDesktopLibrary.so.1.0.0 libTogglDesktopLibrary.so.1.0
rm -f build/release/libTogglDesktopLibrary.so.1.0.0
mv -f libTogglDesktopLibrary.so.1.0.0  build/release/ 
rm -f build/release/libTogglDesktopLibrary.so
rm -f build/release/libTogglDesktopLibrary.so.1
rm -f build/release/libTogglDesktopLibrary.so.1.0
mv -f libTogglDesktopLibrary.so build/release/ 
mv -f libTogglDesktopLibrary.so.1 build/release/ 
mv -f libTogglDesktopLibrary.so.1.0 build/release/ 
make[1]: Leaving directory '/tmp/nix-build-toggl.drv-0/toggldesktop-v7.4.45-src/src/lib/linux/TogglDesktopLibrary'
cp: cannot stat 'third_party/openssl/*so*': No such file or directory
make: *** [Makefile:247: lib] Error 1
builder for ‘/nix/store/lnns2hnp5ykfa50mrama5zcqqpnqgf7g-toggl.drv’ failed with exit code 2
error: build of ‘/nix/store/lnns2hnp5ykfa50mrama5zcqqpnqgf7g-toggl.drv’ failed

@Mic92
Copy link
Member

Mic92 commented Jun 11, 2017

This does not seem qt related, but it seems to ship its own openssl library

cp: cannot stat 'third_party/openssl/*so*': No such file or directory

@spinus
Copy link
Member Author

spinus commented Jun 11, 2017

@Mic92 thanks for checking, LnL took a look and helped me identify some issues yesterday, I fixed some stuff, but still need to fix few.

joachifm
joachifm reviewed Jun 30, 2017
View reviewed changes
pkgs/misc/toggl/default.nix
{ qtbase, poco, fetchFromGitHub, stdenv, makeQtWrapper, perl, readline,
qtx11extras, qtwebkit, qmakeHook ,uncrustify, libXScrnSaver, scrnsaverproto }:
stdenv.mkDerivation {
name = "toggl";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name should contain a version string.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll fix this.
but it's still non working package...

joachifm
joachifm reviewed Jun 30, 2017
View reviewed changes
pkgs/misc/toggl/default.nix
sed -i 's@/usr/local/bin/@@' ./third_party/Xcode-formatter/CodeFormatter/scripts/formatAllSources.sh
'';
preBuild = ''
command -v perl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this accomplish?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It checks if perl is available

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why is this necessary? It is clearly passed as in buildInputs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably not, I had an issue when build mechanism wanted perl but couldn't find that, so I added this line to make sure it's there. I'll def remove that before merge, after this is "buildable".

@lukateras lukateras self-assigned this May 21, 2018
ryantm
ryantm requested changes Sep 8, 2018
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the version to the name and delete unnecessary perl check.

@lukateras
Copy link
Member

Also see https://github.com/NixOS/nixpkgs/blob/93f5e20ef5cfe382ef8f3c38a691144f12a32b1d/pkgs/applications/misc/toggldesktop/default.nix.

@lukateras lukateras removed their assignment Sep 8, 2018
@spinus
Copy link
Member Author

spinus commented Sep 9, 2018

@yegortimoshenko thanks, closing.

@spinus spinus closed this Sep 9, 2018
@spinus spinus deleted the toggl branch September 23, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@Mic92 Mic92 Mic92 left review comments

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: package (new) 9.needs: reporter feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spinus @Mic92 @lukateras @ryantm @joachifm @orivej