grammalecte: init at v0.5.17 #26505
Closed
grammalecte: init at v0.5.17 #26505
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 10, 2017
| @@ -7126,6 +7126,30 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| grammalecte = buildPythonPackage rec { | |||
There was a problem hiding this comment.
This looks like an application and not a python library to me. If this is the case please move it out of python-packages.nix into its own file and reference it in pkgs/top-level/all-packages.nix
There was a problem hiding this comment.
It's also used as a module. ex: https://gitlab.com/geeklhem/flycheck-grammalecte
I can create python-packages and app for cli ?
can i put cli in application/office or in development/libraries like aspell or gtkspell ?
There was a problem hiding this comment.
If it is a python library then you can keep it here. However move the expression to python-modules as described in the header of this file and only keep a reference here.
|
pushed be2b6c2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Grammalecte is an open source grammar checker dedicated to the French language. Grammalecte est un correcteur grammatical open source dédié à la langue française
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)