Turn Random::System into a module (+docs) #4542
Conversation
There was a problem hiding this comment.
To shuffle a deck, I think I would only use system random to initialize a seed for a statistically correct PRNG (e.g. ISAAC or PCG32), which are much much faster; along with an unbiased shuffling technique (swap all cards at least once, if I remember correctly) :-)
|
I just can't come up with a better example, but I feel that it's important to show how to pass this module as as if it's an instance. I removed the comment from it... |
|
This is 👍 for me. If @mverzilli or @bcardiff agrees, please merge :) |
|
@matiasgarciaisaia osx build failed again, just FYI. |
|
Restarted the OSX job that had failed. I know it passed in CircleCI but it feels weird to merge a PR that's red in Travis. Probably OCD, you name it! |
|
It passed BTW |
|
Thanks! |
Fixes #4505