Fix two grave and one interop bug in TOML/YAML meta handling #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. toml.load wants a file handle, toml.loads wants a string 2. `+` has special meaning in regular expressions 3. Require one linebreak after TOML/YAML (as Jekyll does)
|
For anyone else interested, the toml library documentation: https://github.com/uiri/toml/blob/master/README.rst#api-reference |
felixfontein
approved these changes
Jun 11, 2017
| """ | ||
| if data.startswith('---'): # YAML metadata | ||
| split_result = re.split('(\n---\n\n|\r\n---\r\n\r\n)', data.lstrip(), maxsplit=1) |
There was a problem hiding this comment.
So we don't want to expect a double newline after the end of metadata?
There was a problem hiding this comment.
It’s not necessary if we have a --- / +++ separator already. This also mimics Jekyll behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+has special meaning in regular expressionsReleasing v7.8.8 after this merges.